New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access logging due to very nasty bug in Phobos' formatedWrite #808

Merged
merged 3 commits into from Sep 8, 2014

Conversation

Projects
None yet
3 participants
@marcioapm
Contributor

marcioapm commented Sep 4, 2014

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 4, 2014

Member

Looks like something went wrong when merging/rebasing the commits. Can you rebase against the official master branch and skip the commits that don't belong to the PR?

Member

s-ludwig commented Sep 4, 2014

Looks like something went wrong when merging/rebasing the commits. Can you rebase against the official master branch and skip the commits that don't belong to the PR?

@etcimon

This comment has been minimized.

Show comment
Hide comment
@etcimon

etcimon Sep 4, 2014

Contributor

I've had this issue with git before and had to copy the file over to the master repo.

cp source/vibe/core/log.d /tmp/log.d
cp source/vibe/http/log.d /tmp/http_log.d
git reset --hard HEAD
cp /tmp/log.d/ source/vibe/core/log.d
cp /tmp/http_log.d/ source/vibe/http/log.d
git commit ...

Contributor

etcimon commented Sep 4, 2014

I've had this issue with git before and had to copy the file over to the master repo.

cp source/vibe/core/log.d /tmp/log.d
cp source/vibe/http/log.d /tmp/http_log.d
git reset --hard HEAD
cp /tmp/log.d/ source/vibe/core/log.d
cp /tmp/http_log.d/ source/vibe/http/log.d
git commit ...

@marcioapm

This comment has been minimized.

Show comment
Hide comment
@marcioapm

marcioapm Sep 4, 2014

Contributor

here you go, should be good now.

Contributor

marcioapm commented Sep 4, 2014

here you go, should be good now.

Show outdated Hide outdated source/vibe/http/log.d
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 4, 2014

Member

Strange that the AA bug is still triggered, but I'll just ignore that, as it's unlikely to be related with this change. One small issue is that your changes seem to use spaces instead of tabs for indentation. BTW, depending on which editor you use, there may be an EditorConfig plugin available, which is very handy for these kinds of things.

Member

s-ludwig commented Sep 4, 2014

Strange that the AA bug is still triggered, but I'll just ignore that, as it's unlikely to be related with this change. One small issue is that your changes seem to use spaces instead of tabs for indentation. BTW, depending on which editor you use, there may be an EditorConfig plugin available, which is very handy for these kinds of things.

@marcioapm

This comment has been minimized.

Show comment
Hide comment
@marcioapm

marcioapm Sep 4, 2014

Contributor

should be good now - thanks for the EditorConfig tip!

Contributor

marcioapm commented Sep 4, 2014

should be good now - thanks for the EditorConfig tip!

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 8, 2014

Member

OK, thanks! Merging.

Member

s-ludwig commented Sep 8, 2014

OK, thanks! Merging.

s-ludwig added a commit that referenced this pull request Sep 8, 2014

Merge pull request #808 from marcioapm/master
Fix access logging due to very nasty bug in Phobos' formatedWrite

@s-ludwig s-ludwig merged commit 74d039a into vibe-d:master Sep 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment