New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong SSL reference with version(VibeNoSSL) #834

Merged
merged 1 commit into from Sep 20, 2014

Conversation

Projects
None yet
2 participants
@dcarp
Contributor

dcarp commented Sep 19, 2014

Some SSL API is referenced when compiled with version (VibeNoSSL).

Btw. wouldn't it better to use assert(0, ... ); instead of assert(false, ...);? Only assert(0, ...) is specified to not be thrown away when compiled with -release.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Sep 20, 2014

Member

Thanks, merging the fix.

I've always considered using an integer for the assertion condition as sloppy coding style, but you are right that the documentation only mentions assert(0) as a special case (it seems not even assert(0, ...) is mentioned). However, in practice assert(false) has always behaved exactly the same, so that should be fine. But more importantly, I'd strongly discourage using -release for typical vibe.d applications in the first place, as that will also disable bounds checking in most parts of the code, making it potentially vulnerable to buffer overflow attacks.

Member

s-ludwig commented Sep 20, 2014

Thanks, merging the fix.

I've always considered using an integer for the assertion condition as sloppy coding style, but you are right that the documentation only mentions assert(0) as a special case (it seems not even assert(0, ...) is mentioned). However, in practice assert(false) has always behaved exactly the same, so that should be fine. But more importantly, I'd strongly discourage using -release for typical vibe.d applications in the first place, as that will also disable bounds checking in most parts of the code, making it potentially vulnerable to buffer overflow attacks.

s-ludwig added a commit that referenced this pull request Sep 20, 2014

Merge pull request #834 from dcarp/fix_wrong_ssl_reference
Fix wrong SSL reference with version(VibeNoSSL)

@s-ludwig s-ludwig merged commit f95453d into vibe-d:master Sep 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@dcarp dcarp deleted the dcarp:fix_wrong_ssl_reference branch Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment