New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #868 #869

Merged
merged 1 commit into from Oct 17, 2014

Conversation

Projects
None yet
2 participants
@japplegame
Contributor

japplegame commented Oct 17, 2014

JsonStringSerializer.isSupportedValueType!(Nullable!T) equals true if T is numeric type.
This causes serializeImpl to call JsonStringSerializer.writeValue which fails If Nullable!T is empty.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Oct 17, 2014

Member

Thanks, I should have checked the string serializer, since the normal one had the same issue.

Member

s-ludwig commented Oct 17, 2014

Thanks, I should have checked the string serializer, since the normal one had the same issue.

s-ludwig added a commit that referenced this pull request Oct 17, 2014

Merge pull request #869 from japplegame/patch-1
Fix serializing Nullable!T with JsonStringSerializer with numeric T. Fixes #868.

@s-ludwig s-ludwig merged commit 4db9ca3 into vibe-d:master Oct 17, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@japplegame japplegame deleted the japplegame:patch-1 branch Oct 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment