New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Websocket pinging. #883

Merged
merged 1 commit into from Oct 27, 2014

Conversation

Projects
None yet
2 participants
@Eximius
Contributor

Eximius commented Oct 27, 2014

When vibe.d received a ping frame, it set the frame's opcode to pong and sent the pong message, it broke out of the switch and the loop as well (since the opcode is no longer ping), which left the m_currentFrame in a zeroed out state so Websocket receive complained about unexpected continuation frame and closed the connection.

Heartbeat made the connection go away - sweet irony.

Fix Websocket pinging.
When vibe.d received a ping frame, it set the frame's opcode to pong and sent the pong message, it broke out of the switch and the loop as well (since the opcode is no longer ping), which left the m_currentFrame in a zeroed out state so Websocket receive complained about unexpected continuation frame and closed the connection.

Heartbeat made the connection go away - sweet irony.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Oct 27, 2014

Member

Thanks! That part of the protocol has never really been tested so far (it was implemented when WebSockets were still in their infancy).

Member

s-ludwig commented Oct 27, 2014

Thanks! That part of the protocol has never really been tested so far (it was implemented when WebSockets were still in their infancy).

s-ludwig added a commit that referenced this pull request Oct 27, 2014

@s-ludwig s-ludwig merged commit 9264360 into vibe-d:master Oct 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment