New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/i18n enhancement #896

Merged
merged 2 commits into from Jan 16, 2015

Conversation

Projects
None yet
3 participants
@ncoe
Contributor

ncoe commented Nov 12, 2014

Adding some unittests to the translation framework in the vibe.web.web module.
Adding support for the msgctxt tag that can be specified in po files.

ncoe added some commits Nov 9, 2014

Added some unittests for extractDeclStrings. This should resolve issue
…#1.

Added support for string wrapping. This should also have a unittest defined for it.
Implementing support for msgctxt, which can assist in disambiguating
msgid's that would otherwise overwrite any others. This should resolve
issue #2
string key;
string value;
}
string keyToIdentifier(string key)

This comment has been minimized.

@Geod24

Geod24 Nov 15, 2014

Contributor

You could just remove the code instead of commenting it.

@Geod24

Geod24 Nov 15, 2014

Contributor

You could just remove the code instead of commenting it.

This comment has been minimized.

@ncoe

ncoe Nov 15, 2014

Contributor

I could do that if I get around to plural support before this commit gets pulled.

@ncoe

ncoe Nov 15, 2014

Contributor

I could do that if I get around to plural support before this commit gets pulled.

* msgstr[2] - ditto and etc...
*/
// TODO: Handle msgctxt

This comment has been minimized.

@s-ludwig

s-ludwig Jan 15, 2015

Member

I there something still left for msgctxt?

@s-ludwig

s-ludwig Jan 15, 2015

Member

I there something still left for msgctxt?

This comment has been minimized.

@ncoe

ncoe Jan 16, 2015

Contributor

The msgcntxt should be complete, and that TODO can be removed. The only thing remaining should be additional overloads that support plurals and context for plurals.

@ncoe

ncoe Jan 16, 2015

Contributor

The msgcntxt should be complete, and that TODO can be removed. The only thing remaining should be additional overloads that support plurals and context for plurals.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jan 15, 2015

Member

I'd pull this and then remove the commented out code if there are no objections.

Member

s-ludwig commented Jan 15, 2015

I'd pull this and then remove the commented out code if there are no objections.

s-ludwig added a commit that referenced this pull request Jan 16, 2015

@s-ludwig s-ludwig merged commit f556f83 into vibe-d:master Jan 16, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

s-ludwig added a commit that referenced this pull request Jan 16, 2015

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jan 16, 2015

Member

Okay, thanks! I've removed the commented out code; if necessary, we can always dig it up from the GIT history.

Member

s-ludwig commented Jan 16, 2015

Okay, thanks! I've removed the commented out code; if necessary, we can always dig it up from the GIT history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment