New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPClientResponse.switchProtocol() #945

Merged
merged 1 commit into from May 1, 2015

Conversation

Projects
None yet
3 participants
@lultimouomo
Contributor

lultimouomo commented Dec 29, 2014

Replaces vibe-d/vibe.d#929 which I accidentally opened on my master branch.

Since the response does not have access to the request headers,
the expected protocol must be supplied as a parameter.

This is needed, for instance, to create client-side websockets.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jan 15, 2015

Member

Maybe switchProtocol would be a better naming choice, because it would be consistent with HTTPServerResponse.switchProtocol. Other than that, I just noticed that for both, HTTPServerRespose and HTTPClientResponse, an additional overload taking a scoped delegate to handle the connection would be good to have, to avoid the GC new. But that is independent of this pull request.

Member

s-ludwig commented Jan 15, 2015

Maybe switchProtocol would be a better naming choice, because it would be consistent with HTTPServerResponse.switchProtocol. Other than that, I just noticed that for both, HTTPServerRespose and HTTPClientResponse, an additional overload taking a scoped delegate to handle the connection would be good to have, to avoid the GC new. But that is independent of this pull request.

Add HTTPClientResponse.switchProtocol()
Since the response does not have access to the request headers,
the expected protocol must be supplied as a parameter.

Signed-off-by: Luca Niccoli <l.niccoli@awtech.it>

@lultimouomo lultimouomo changed the title from Add HTTPClientResponse.upgradeConnection() to Add HTTPClientResponse.switchProtocol() Feb 23, 2015

s-ludwig added a commit that referenced this pull request May 1, 2015

Merge pull request #945 from lultimouomo/upgradeConnection
Add HTTPClientResponse.switchProtocol()

@s-ludwig s-ludwig merged commit 83ba753 into vibe-d:master May 1, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment