New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RedisSessionStore.create() #996

Merged
merged 1 commit into from Mar 4, 2015

Conversation

Projects
None yet
2 participants
@YusukeSuzuki
Contributor

YusukeSuzuki commented Feb 27, 2015

redis doesn't let empty hash. so insert place holder to initial
session key-value.

Fix RedisSessionStore.create()
redis doesn't let empty hash. so insert place holder to initial
session key-value.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Mar 4, 2015

Member

Thanks! Using the session key seemed a bit odd to me at first, but really it should be as good as anything else. I would probably have opted for something like "__placeholder", "", but this is ok, too.

Member

s-ludwig commented Mar 4, 2015

Thanks! Using the session key seemed a bit odd to me at first, but really it should be as good as anything else. I would probably have opted for something like "__placeholder", "", but this is ok, too.

s-ludwig added a commit that referenced this pull request Mar 4, 2015

@s-ludwig s-ludwig merged commit 48e1e26 into vibe-d:master Mar 4, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment