Fix the treatment of broken symlink #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`os.path.exists(f)` and `os.path.isfile(f)` return `False` when the `f` is a broken symlink. This causes dotty to skip the entire existing-file logic and try to link an existing file, resulting in `FileExistsError: [Errno 17]`. Even if the logic was used, dotty attempts to remove the broken symlink as directory, because `os.path.isfile(f)` says it's not a file. Using `os.path.lexists` and determining whether the symlink is broken fixes the problem.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.exists(f)andos.path.isfile(f)returnFalsewhen thefis a broken symlink. This causes dotty to skip the entire existing-file
logic and try to link an existing file, resulting in
FileExistsError: [Errno 17]. Even if the logic was used, dotty attempts to remove thebroken symlink as directory, because
os.path.isfile(f)says it's nota file.
Using
os.path.lexistsand determining whether the symlink is brokenfixes the problem.