dont filter on root prefix. #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example, if user does `import-tree ./_foo`, explicitly asking to traverse `./_foo`, then results must be `./_foo/bar.nix` but not `./_foo/_baz.nix`. that is, filtering occurs only on after-root paths.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the filtering behavior for import-tree to apply filtering only to paths after the root directory, not to the root itself. This allows users to explicitly traverse directories with underscore prefixes (e.g., ./_foo) while still filtering out underscore-prefixed subdirectories.
Key changes:
- Introduced relative path tracking to distinguish between root paths and their subdirectories
- Modified the filtering logic to apply filters only to paths after the root directory
- Added test coverage for loading from hidden directories while excluding sub-hidden paths
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tree/a/b/_c/d/_f.nix | Added test fixture file in underscore-prefixed directory |
| default.nix | Implemented makeRelative and rootRelative functions to track relative paths and apply filtering only after root |
| checkmate.nix | Added test case verifying that underscore-prefixed root can be traversed while filtering its subdirectories |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example, if user does
import-tree ./_foo,explicitly asking to traverse
./_foo, then results must be./_foo/bar.nixbut not./_foo/_baz.nix.that is, filtering occurs only on after-root paths.