Allow repeated applications of filtered, matching, and mapWith
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome! Looks good 👍 Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
filtered,matching, andmapWithfunctions composable, such that when applied repeatedly, they combine their effects instead of overriding the previous applications.I've updated the README to showcase a few examples, and added test cases for the new functionality.
I've also done some minor improvements to the code, e.g. removed the call to
lib.toList(becauseflattenalready does that if its input isn't a list), and replacedlibfunctions with theirbuiltinsequivalents (where applicable).