Victor Berchet vicb

Organizations

@angular @ultimatepp
vicb created branch 0330-test at vicb/angular
vicb commented on pull request angular/angular#1136
vicb opened pull request angular/angular#1157
@vicb
doc(lifecycle): minor fixes
1 commit with 6 additions and 4 deletions
@vicb
  • @vicb 5e60e99
    doc(lifecycle): minor fixes
vicb pushed to cpp at ultimatepp/upp
@vicb
vicb created branch cpp at ultimatepp/upp
vicb created branch android_builder at ultimatepp/upp
vicb commented on issue angular/angular#1144
@vicb

duplicate of #615 There is a google doc (early stage) attached in this issue, feel free to comment there

vicb closed issue angular/angular#1144
@vicb
Test bed and user story for Angular 2
vicb commented on pull request angular/angular#1136
@vicb

nitpick : + WS (consistency)

vicb commented on pull request angular/angular#1136
@vicb

not sure if we should throw here or only return null Someone might with a plugin that would support keydown.fancymodifier chained with this one

vicb commented on pull request angular/angular#1136
@vicb

alert would not work in Dart

vicb commented on pull request angular/angular#1136
@vicb

you need to initialize the reflector for this to work in Dart, see other examples

vicb commented on pull request angular/angular#1136
@vicb

factorize the 2 methods by passing shouldSupportBubble ?

vicb commented on pull request angular/angular#1136
@vicb

return type

vicb commented on pull request angular/angular#1136
@vicb

add return type :string

vicb commented on pull request angular/angular#1136
@vicb

3 -> constant ?

vicb commented on pull request angular/angular#1136
@vicb

, + WS

vicb commented on pull request angular/angular#1136
@vicb

minor: WS after , in ListWrapper.removeAt(parts,0); no WS after if (

vicb commented on pull request angular/angular#1136
@vicb

Not sure if Dart allow removing in a forEach. Anyway a counter might perform better.

vicb commented on pull request angular/angular#1136
@vicb

!! would not work with Dart, isPresent() ?

vicb commented on pull request angular/angular#1136
@vicb

could you please use double or single quotes consistently (single preferred)

vicb commented on pull request angular/angular#1136
@vicb

eventName.split('.') & drop the regexp

vicb pushed to master at angular/angular
@vicb
  • @vicb c8385ad
    refactor(cd): remove dead code
vicb merged pull request angular/angular#1135
@vicb
refactor(cd): remove dead code
1 commit with 0 additions and 2 deletions
vicb opened pull request angular/angular#1135
@vicb
refactor(cd): remove dead code
1 commit with 0 additions and 2 deletions
vicb created branch 0327-cddc at vicb/angular
vicb pushed to trunk at ultimatepp/upp
@vicb