Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish API documentation #1

Closed
vickumar1981 opened this issue Jul 5, 2018 · 8 comments
Closed

Finish API documentation #1

vickumar1981 opened this issue Jul 5, 2018 · 8 comments

Comments

@vickumar1981
Copy link
Owner

Need to put annotated comments in more files. The docs are incomplete and could use more explanation of what each of the methods and parameters do.

@ghost
Copy link

ghost commented Jul 11, 2018

hi there. I'd like to pitch in and help your community with documentation support if possible.

@vickumar1981
Copy link
Owner Author

vickumar1981 commented Jul 16, 2018

@reneleft01 thanks.

to run the docs you use: sbt doc, assuming you have sbt setup - https://www.scala-sbt.org/1.0/docs/Setup.html

there's only a few places where the documentation is okay, but even there it can be improved:

https://github.com/vickumar1981/stringdistance/blob/master/src/main/scala/com/github/vickumar1981/stringdistance/package.scala#L7

https://github.com/vickumar1981/stringdistance/blob/master/src/main/scala/com/github/vickumar1981/stringdistance/StringDistance.scala#L6

https://github.com/vickumar1981/stringdistance/blob/master/src/main/scala/com/github/vickumar1981/stringdistance/StringSound.scala#L6

Everywhere else, documentation is needed, and particularly for the Java interface and the implementations.

@rjseymour66
Copy link

Hi All,
Do you still need help with the documentation? I didn't see that this issue is closed.

I am a professional technical writer and would like to assist, if that is still needed.

@vickumar1981
Copy link
Owner Author

Hi @rjseymour66 .

Definitely still need help with the documentation. The repo is using scaladocs: https://docs.scala-lang.org/overviews/scaladoc/for-library-authors.html . Please feel free to shoot me an email or DM me on Twitter, vickumar1981. Thank you also.

@rjseymour66
Copy link

Great! I will take a closer look over the weekend and respond with any questions/suggestions.

@vickumar1981
Copy link
Owner Author

vickumar1981 commented Dec 3, 2018

Started working on the documentation: #18

Basic usage of scala docs:

@vickumar1981
Copy link
Owner Author

vickumar1981 commented Dec 3, 2018

Until the CONTRIBUTING.md is complete,here's the general instructions for working with the documentation:

  1. Need java 8 installed - https://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html
  2. Clone the repo, specifically checkout the snapshot branch (currently, 1.0.8-SNAPSHOT)
  3. Run ./sbt doc
  4. The index.html file for the docs will be generated under target/scala-2.12/api

@vickumar1981
Copy link
Owner Author

Closing and creating separate issues per top level package:

#30
#31
#32
#33
#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants