New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds translation to the Twitter share text #104

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@emembrives
Contributor

emembrives commented Nov 4, 2018

This branch is based on my other pull request (due to the base French translation), but it is a somewhat independent bug fix.

@hanzei

This comment has been minimized.

Collaborator

hanzei commented Nov 8, 2018

Thanks for the contribution, good catch!

But I would rather remove the language depended text in the twitter share text. This would also make it consistent with the other share texts.

Would you like to provide a fix for this?

@emembrives

This comment has been minimized.

Contributor

emembrives commented Nov 8, 2018

Sure, I'll do that.

@emembrives

This comment has been minimized.

Contributor

emembrives commented Nov 8, 2018

You can review now :-)

@hanzei hanzei self-requested a review Nov 9, 2018

@hanzei

hanzei approved these changes Nov 9, 2018

👍

@hanzei hanzei merged commit ae32991 into vickylai:master Nov 9, 2018

@hanzei

This comment has been minimized.

Collaborator

hanzei commented Nov 9, 2018

Thanks @emembrives!

@hanzei hanzei added this to the v4.0.1 milestone Nov 9, 2018

@emembrives emembrives deleted the emembrives:twitter branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment