New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fa icon packs #113

Merged
merged 3 commits into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@apreshill
Copy link
Contributor

apreshill commented Dec 13, 2018

Hi Vicky,

I'm enjoying using this theme- thank you! I noticed you recently updated the theme to include Font Awesome 5, but only the "brand" package (fab was allowed for the social icons in layouts/partials/home/social.html). But, the solid icons are there and available.

    [[params.social]]
        url   = "https://twitter.com/"
        icon  = "twitter"
    [[params.social]]
        url   = "https://facebook.com/"
        icon  = "facebook-f"
    [[params.social]]
        url   = "https://linkedin.com/"
        icon  = "linkedin-in"
    [[params.social]]
        url   = "mailto:youremail@email.com"
        icon  = "paper-plane"

screen shot 2018-12-13 at 1 51 01 pm

This PR adds functionality for users to specify which icon_pack to use (fas or fab; see: https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4) in the config.toml file, so that users can use the solid icons as well as the brand icons.

    [[params.social]]
        url   = "https://twitter.com/"
        icon  = "twitter" # icon name without the 'fa-'
        icon_pack = "fab"
    [[params.social]]
        url   = "https://facebook.com/"
        icon  = "facebook-f" # icon name without the 'fa-'
        icon_pack = "fab"
    [[params.social]]
        url   = "https://linkedin.com/"
        icon  = "linkedin-in" # icon name without the 'fa-'
        icon_pack = "fab"
    [[params.social]]
        url = "mailto:youremail@email.com"  # For a direct email link, use "mailto:test@example.org".
        icon = "paper-plane" # icon name without the 'fa-'
        icon_pack = "fas"

screen shot 2018-12-13 at 1 49 18 pm

Thank you again!
Alison

@hanzei hanzei self-requested a review Dec 14, 2018

@hanzei hanzei self-assigned this Dec 14, 2018

@hanzei hanzei added this to the v4.0.1 milestone Dec 14, 2018

@hanzei hanzei added the enhancement label Dec 14, 2018

@hanzei

hanzei approved these changes Dec 14, 2018

Copy link
Collaborator

hanzei left a comment

Test and works. LGTM 👍

@hanzei hanzei merged commit 2c5cfbc into vickylai:master Dec 14, 2018

@hanzei

This comment has been minimized.

Copy link
Collaborator

hanzei commented Dec 14, 2018

Thanks you very much for the PR @apreshill!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment