LPS-119582 Reset the state of merge layout prototypes thread local #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… restart sidecar if it has never successfully started before https://issues.liferay.com/browse/LPS-121254
…st function Element.closest() docs: https://developer.mozilla.org/en-US/docs/Web/API/Element/closest metal-dom `closest` function: https://github.com/metal/metal.js/blob/466812085dd29e37c90b835c64cb49555d76a294/packages/metal-dom/src/domNamed.js#L163..L167
…ains function metal-dom contains implementation: https://github.com/metal/metal.js/blob/466812085dd29e37c90b835c64cb49555d76a294/packages/metal-dom/src/domNamed.js#L218..L225 Node.contains mdn reference: https://developer.mozilla.org/en-US/docs/Web/API/Node/contains
… function Element.matches mdn docs: https://developer.mozilla.org/en-US/docs/Web/API/Element/matches dom.match implementation: https://github.com/metal/metal.js/blob/466812085dd29e37c90b835c64cb49555d76a294/packages/metal-dom/src/domNamed.js#L418
…that havent been converted from the "deflt" format to a proper array https://issues.liferay.com/browse/LPS-118944
…uments in javascript methods
…s the child element
…ch task will run on single/all nodes in the cluster
… multiple if conditions which would determine which storageType should be used + add singleNodeExecution service logic
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Hey @vicnate5, integration test failure is fixed here. and DB partitioning issue is reproducible even without this PR, please see https://issues.liferay.com/browse/LPS-122281 for details. |
|
ci:test:sf |
|
ci:test:relevant |
|
ci:test |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: pr-1585 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#2118 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#3484 |
✔️ ci:test:stable - 9 out of 9 jobs passed✔️ ci:test:relevant - 23 out of 24 jobs passed in 5 hours 57 minutesClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private ci:test:stable - 9 out of 9 jobs PASSED9 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED2 Failed Jobs:22 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at b57b964:
Test bundle downloads:
|
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#3908 |
|
@pavel-savinov I am unable to reproduce https://issues.liferay.com/browse/LPS-122281 at head on master and the poshi test for this scenario is passing at head. On this PR, I am unable to access a new virtual instance that uses database partitioning. The poshi test is also failing. The new virtual instance URL causes a redirect loop. I manually checked this multiple times on a master bundle vs this PR bundle. Detailed steps to reproduce the Regression:
URL modified to This database partitioning feature is critical for Portal offering SaaS on DXP Cloud. |
|
Just started reviewing :) |
1 similar comment
|
Just started reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.