Skip to content

Loading…

use deactivate-mark instead of (set-mark nil) #19

Closed
wants to merge 1 commit into from

2 participants

@lewang
Collaborator

setting the mark to nil broke C-SPC C-SPC for me.

@victorhge
Owner

There is another " (set-mark nil) " in iedit.el. Please replace it also.

@victorhge
Owner

What is expected here actually is
(setq mark-active nil)
(run-hooks 'deactivate-mark-hook)
Neither "deactivate-mark" nor "(set-mark nil)" works in all situation.

I will fix it by myself.

The closest is "(deactivate-mark t)". But it is not available in Emacs 22.

@victorhge victorhge closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 30, 2012
  1. use deactivate-mark instead of (set-mark nil)

    Le Wang committed
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1 iedit-rect.el
  2. +1 −1 iedit.el
View
2 iedit-rect.el
@@ -97,7 +97,7 @@ Commands:
(if (iedit-region-active)
(let ((beg (region-beginning))
(end (region-end)))
- (set-mark nil)
+ (deactivate-mark)
(iedit-rectangle-start beg end)))))
(defun iedit-rectangle-start (beg end)
View
2 iedit.el
@@ -330,7 +330,7 @@ Keymap used within overlays:
(setq beg (region-beginning))
(setq end (region-end)))))
(setq iedit-only-complete-symbol-local complete-symbol)
- (set-mark nil)
+ (deactivate-mark)
(setq iedit-case-sensitive-local iedit-case-sensitive-default)
(iedit-start occurrence beg end))))
Something went wrong with that request. Please try again.