use deactivate-mark instead of (set-mark nil) #19

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@lewang
Collaborator

lewang commented Aug 30, 2012

setting the mark to nil broke C-SPC C-SPC for me.

@victorhge

This comment has been minimized.

Show comment Hide comment
@victorhge

victorhge Aug 31, 2012

Owner

There is another " (set-mark nil) " in iedit.el. Please replace it also.

Owner

victorhge commented Aug 31, 2012

There is another " (set-mark nil) " in iedit.el. Please replace it also.

@victorhge

This comment has been minimized.

Show comment Hide comment
@victorhge

victorhge Aug 31, 2012

Owner

What is expected here actually is
(setq mark-active nil)
(run-hooks 'deactivate-mark-hook)
Neither "deactivate-mark" nor "(set-mark nil)" works in all situation.

I will fix it by myself.

The closest is "(deactivate-mark t)". But it is not available in Emacs 22.

Owner

victorhge commented Aug 31, 2012

What is expected here actually is
(setq mark-active nil)
(run-hooks 'deactivate-mark-hook)
Neither "deactivate-mark" nor "(set-mark nil)" works in all situation.

I will fix it by myself.

The closest is "(deactivate-mark t)". But it is not available in Emacs 22.

@victorhge victorhge closed this Aug 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment