Emacs crash when activating rectangle mode and region is not rectangular. #31

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

No description provided.

Also when trying to deactivate mode, rectangle mode is called with nil args (both for beg and end) and raise an error.

Collaborator
lewang commented Jan 19, 2013

@thierryvolpiatto Can you add repro steps in a test-case? Also have you filed a Emacs bug? It shouldn't crash no matter what, right?

Collaborator
lewang commented Jan 19, 2013

@thierryvolpiatto I forgot to say my Emacs crashed while using iedit a few days ago as well, so I'm glad you found the possible reason!

Le Wang notifications@github.com writes:

@thierryvolpiatto Can you add repro steps in a test-case?

Here some text: cursor is at "!"

"!"It shouldn't crash no matter what
It shouldn't crash no matter what
It shouldn't crash no matter what
It shouldn't crash no matter what
It shouldn't crash no matter what

C-
C-n C-n C-n C-n C-n

C-RET (iedit-rectangle-mode)
Emacs hangs forever, now C-g and Emacs crash.

Also have you filed a Emacs bug?
No.

It shouldn't crash no matter what, right?
Yes.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

Collaborator
lewang commented Jan 19, 2013

On Sat, Jan 19, 2013 at 3:02 PM, Thierry Volpiatto <notifications@github.com

wrote:

Le Wang notifications@github.com writes:

@thierryvolpiatto Can you add repro steps in a test-case?

Here some text: cursor is at "!"

"!"It shouldn't crash no matter what
It shouldn't crash no matter what
It shouldn't crash no matter what
It shouldn't crash no matter what
It shouldn't crash no matter what

C-
C-n C-n C-n C-n C-n

C-RET (iedit-rectangle-mode)
Emacs hangs forever, now C-g and Emacs crash.

Nice! I've reproed on MAC build OS X with 24.2.1. Crashes exactly as you
describe.

Also have you filed a Emacs bug?
No.
It shouldn't crash no matter what, right?
Yes.

Ok. Can you send along the BUG # when you get it? I just did a quick
search in the bug DB and didn't see it.

Thanks.

Le

Le Wang notifications@github.com writes:

Also have you filed a Emacs bug?
No.
It shouldn't crash no matter what, right?
Yes.

Ok. Can you send along the BUG # when you get it?
I won't, can you do it?

I just did a quick search in the bug DB and didn't see it.
Probably you have to open a new one.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

Owner

Superceded by Pull request 34

@victorhge victorhge closed this Feb 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment