Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the role of docs #116

Closed
VincentTam opened this issue Dec 18, 2018 · 5 comments
Closed

What is the role of docs #116

VincentTam opened this issue Dec 18, 2018 · 5 comments
Labels

Comments

@VincentTam
Copy link
Contributor

VincentTam commented Dec 18, 2018

The project owner says that docs is generated from exampleSite in #85. The generated HTML source code is once again posted in a separated GitHub repo "introduction". I find that a bit complicated. I wonder why GitHub's built-in gh-pages branch is not utilised for hosting the theme's demo site, unlike Octopress. Putting them in one single repo helps us focus better during code exploration.

In fact, Git is not made for tracking generated code.

Besides, after running hugo server ... to locally preview the demo site, two files were automatically generated under exampleSite/resources/_gen. I wonder why there're files tracked in that repo. When one creates a PR, one also needs to include the changes in that repo?

I am quite confused about these two folders with generated code. I would welcome any thoughts about this.

@hanzei
Copy link
Collaborator

hanzei commented Dec 19, 2018

https://github.com/vickylai/introduction is not longer used and should be removed.

What advantages do you see with using a gh-pages branch of the example site?

Besides, after running hugo server ... to locally preview the demo site, two files were automatically generated under exampleSite/resources/_gen. I wonder why there're files tracked in that repo. When one creates a PR, one also needs to include the changes in that repo?

These two files should not be checked it. There are generated in https://github.com/vickylai/hugo-theme-introduction/blob/master/layouts/partials/head/css.html depending of you using hugo or hugo server.

We check in exampleSite/resources/_gen because then people can just clone the repo and run it.

@VincentTam
Copy link
Contributor Author

Thanks for your explanation. I've abandoned GitHub Pages for a year, and I've recently switched to GitLab Pages, so please excuse me for the question in the title, as well as the question about gh-pages branch. I've just realised that GitHub has changed the technical details, so that it's now possible to build GitHub pages from master/docs.

@hanzei
Copy link
Collaborator

hanzei commented Dec 19, 2018

I see that isn't not idiomatic to include the generated source of the example site in this repo. But I don't see an easier other way.

@hanzei
Copy link
Collaborator

hanzei commented Jan 6, 2019

I think the lesson learned from this is, that docs should not be regenerated by contributors. Every time we do a release we should update docs.

@VincentTam are you fine if I close this one?

@VincentTam
Copy link
Contributor Author

👌

@hanzei hanzei closed this as completed Jan 6, 2019
@hanzei hanzei added the question label Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants