Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with hyphens in file validation mime types #650

Merged

Conversation

@nholden
Copy link
Contributor

@nholden nholden commented Oct 4, 2017

Addresses #646, which reported that mime types in file validations were being parsed incorrectly when they contained hyphens. This change ensures that we only split the allowed file types string at commas and trailing white space and not at hyphens.

Addresses #646, which reported that mime types in file validations were
being parsed incorrectly when they contained hyphens. This change
ensures that we only split the allowed file types string at commas and
trailing white space and not at hyphens.
@victorjonsson victorjonsson merged commit dc69da7 into victorjonsson:master Apr 18, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@victorjonsson
Copy link
Owner

@victorjonsson victorjonsson commented Apr 18, 2018

Great!

@nholden nholden deleted the nholden:fix-mime-type-validation branch Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.