Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Devise for VictoryKit #46

merged 8 commits into from Aug 29, 2013


None yet
3 participants

mjsteckel commented Aug 29, 2013

Should be good to go.

Mark Steckel and others added some commits Aug 26, 2013

Mark Steckel Initial comment for Devise related changes. There are tests that stil…
…l need to be fixed and cruft to clean up...
Mark Steckel Fixed some outstanding tests after switching to Devise. Also set
some to "pending" as I don't know how to fix them yet.
Mark Steckel Post Devise cruft removal fb8531b
Mark Steckel Forgot to renable the Devise 'lockable' module. 7f2e13f
@woodhull woodhull (+Brian) Removed AdminConstraint entirely and fixed pending specs by …
…removing session override.
Mark Steckel Remove crufty code post-Devise a2f1af1
Mark Steckel Removed custom change password code and offloaded to Devise. Also rem…
…oved custom tests for same.

Note: Devise requires attr_accessible for password & password_confirmation.

woodhull commented Aug 29, 2013

Brian, can you just check this one last time and merge when you get a chance?


bguthrie commented Aug 29, 2013

I've just pushed a few minor changes––the debug: false flag snuck back in again, and there were a couple of other spots that needed a small bit of cleaning. Besides these, everything looks great to me––thanks for the work.


mjsteckel commented Aug 29, 2013

Unless anyone speaks up, I will merge the pull request this afternoon (PST).


bguthrie commented Aug 29, 2013

I was just waiting for the build to pass, but I'm happy to merge now.

@bguthrie bguthrie added a commit that referenced this pull request Aug 29, 2013

@bguthrie bguthrie Merge pull request #46 from victorykit/devise
Devise for VictoryKit

@bguthrie bguthrie merged commit e7ef0ca into master Aug 29, 2013

1 check passed

default The build passed on Semaphore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment