Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemsChanged not always handled correctly #145

Closed
dirkjanfaber opened this issue Sep 14, 2022 · 0 comments
Closed

ItemsChanged not always handled correctly #145

dirkjanfaber opened this issue Sep 14, 2022 · 0 comments
Assignees
@dirkjanfaber

Comments

@dirkjanfaber
Copy link
Collaborator

See issue #143. Located and easily reproducible with digital input messages (but not limited to that).

Not all ItemsChanged messages are handled correctly (in issue #111), therefor missing some changed values.
@dirkjanfaber dirkjanfaber self-assigned this Sep 14, 2022
@dirkjanfaber dirkjanfaber mentioned this issue Sep 14, 2022
Closed
dirkjanfaber added a commit that referenced this issue Sep 14, 2022
@dirkjanfaber
Fix in ItemsChanged
112d550 
- ItemsChanged messages were only handled properly when not in an
array. This parses them in all cases. Fixes issue #145, see also
issues #111 and #143.
dirkjanfaber added a commit that referenced this issue Sep 14, 2022
@dirkjanfaber
Fix in ItemsChanged
bd25ee2 
- ItemsChanged messages were only handled properly when not in an array. This parses them in all cases. Fixes issue #145, see also
issues #111 and #143.
dirkjanfaber added a commit that referenced this issue Sep 15, 2022
@dirkjanfaber
Fix for multiple items in ItemsChanged array
476a315 
In case of an ItemsChanged package, only the last of the items that was in the received array was being parsed correctly. This change fixes that and parsers all items from the array, resolving issue #145.
Thus far this bug had gone unnoticed as there are several nodes that have such few changes per second that the ItemsChanged array often consists of a single item. Each item is also polled every 5 seconds (pollInterval), which was always parsed correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirkjanfaber dirkjanfaber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dirkjanfaber