Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Being able to set QOS #44

Closed
tcz opened this Issue · 13 comments

4 participants

@tcz

Hi,

I think for multiple consumers to work properly it's important to be able to set QOS for channels.
See: http://www.rabbitmq.com/amqp-0-9-1-reference.html#basic.qos

@videlalvaro
Owner

what do you think the default QOS should be?

@tcz

As of me, I don't need prefetch (or maybe a prefetch count 1) because I work with small messages but I might launch multiple consumers.

@asm89

The default QoS as defined by RabbitMQ assumes that the client has an unlimited buffer, so it will send out as much messages as it can to the client. If you want to add multiple consumers to a queue, but one of the consumers already has all the messages in its buffer the new consumers will remain idle.

Maybe it's an idea to add qos.prefetch_size and qos.prefetch_count options to the consumer configuration? The base consumer can set appropriate options for the channel.

@videlalvaro
Owner

I will look into this or someone can start writing a patch ;)

@asm89

I can probably write up a patch for this, but it's probably a good idea to have #50 merged first. ;)

@videlalvaro
Owner

We are working on getting that merged ASAP :)

@videlalvaro
Owner

@asm89 you are good to go ;)

@asm89

Would you still like a PR for this? Do you like the parameters I suggested above?

@videlalvaro
Owner

Sorry I've been off for a while. Yes I want a patch

@seb0zz

We implemented configurable QOS support so that the developer is able to set prefetch_size and prefetch_count for each consumer.

See #64

@videlalvaro
Owner

@tcz can we close this issue?

@tcz
tcz commented

Hi,

I did not have the opportunity to test this but I'm sure it works. Thanks!

@videlalvaro
Owner

@tcz seems legit :P

@videlalvaro videlalvaro closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.