New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't try to load embedded audio tracks #1907

Merged
merged 1 commit into from Sep 19, 2018

Conversation

2 participants
@valotvince
Contributor

valotvince commented Aug 30, 2018

Hi 馃槃

This PR will...

Fix an issue introduced since version 0.10.0 that was trying to fetch an embedded audioTrack in the main playlist.
As it doesn't have an URI tag, that embedded track had an undefined url, which means the audioTrack controller was trying to fetch the ${hostname}/undefined

Why is this Pull Request needed?

Because it makes a 404 request on our platform at each video loading

Are there any points in the code the reviewer needs to double check?

Here is a manifest with an embedded audioTrack in the main playlist: https://cdn-rtlhu.akamaized.net/videos/rtlhu/usp/mb_sd3/9/e/1/Survivor_c12058981_Survivor-A-sziget-2-/Survivor_c12058981_Survivor-A-sziget-2-_unpnp.ism/Manifest.m3u8

A multiple languages manifest still works fine: https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@johnBartos johnBartos added this to the 0.11.1 milestone Sep 19, 2018

@johnBartos

johnBartos approved these changes Sep 19, 2018 edited

The value is a quoted-string containing a URI that identifies the
Media Playlist file. This attribute is OPTIONAL; see
Section 4.3.4.2.1. If the TYPE is CLOSED-CAPTIONS, the URI
attribute MUST NOT be present.

Good catch!

@johnBartos johnBartos merged commit 7794b4f into video-dev:master Sep 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@johnBartos johnBartos added the Bug label Oct 9, 2018

@robwalch robwalch referenced this pull request Oct 25, 2018

Merged

Avoid loading audio-track with undefined url #182

2 of 3 tasks complete

@johnBartos johnBartos added this to Done in 0.11.1 Release Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment