Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent loading key format #2606

merged 2 commits into from Mar 26, 2020


Copy link

This PR will...

Prevent trying to load a format skd://... and warn the integrator this isn't supported out-of-the-box by hls.js

Why is this Pull Request needed?

I am working on playing HLS fMP4 w/ Fairplay encryption with hls.js and it was creating an error while trying to load skd:// over HTTP.
Preventing it allows segments to be added to Buffer/MediaSource and therefore trigger the webkitneedkey and webkitkeymessage events that I need to get a license from our DRM provider

Are there any points in the code the reviewer needs to double check?

Any other KEYFORMAT should work


  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in

Copy link

@valotvince thanks for the contribution. Would you consider contributing a fairplay implementation as well? It would be great if we could handle webkitneedkey and webkitkeymessage via the eme-controller or a fairplay variant of that controller specifically for the webkit prefixed API.

Copy link
Contributor Author

@robwalch Hello :)
I am still developing that feature (out of hls.js) but I'll contribute as soon as I have something working on my end !

@robwalch robwalch added this to the 0.14.0 milestone Mar 26, 2020
@robwalch robwalch merged commit b729d19 into video-dev:master Mar 26, 2020
Copy link

@valotvince look forward to your contribution for FairPlay support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants