Skip to content

Prevent loading com.apple.streamingkeydelivery key format - #2606

Merged
robwalch merged 2 commits into
video-dev:masterfrom
valotvince:fix-unsupported-kf
Mar 26, 2020
Merged

Prevent loading com.apple.streamingkeydelivery key format#2606
robwalch merged 2 commits into
video-dev:masterfrom
valotvince:fix-unsupported-kf

Conversation

@valotvince

Copy link
Copy Markdown
Contributor

This PR will...

Prevent trying to load a com.apple.streamingkeydelivery format skd://... and warn the integrator this isn't supported out-of-the-box by hls.js

Why is this Pull Request needed?

I am working on playing HLS fMP4 w/ Fairplay encryption com.apple.fps.2_0 with hls.js and it was creating an error while trying to load skd:// over HTTP.
Preventing it allows segments to be added to Buffer/MediaSource and therefore trigger the webkitneedkey and webkitkeymessage events that I need to get a license from our DRM provider

Are there any points in the code the reviewer needs to double check?

Any other KEYFORMAT should work

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch

Copy link
Copy Markdown
Collaborator

@valotvince thanks for the contribution. Would you consider contributing a fairplay implementation as well? It would be great if we could handle webkitneedkey and webkitkeymessage via the eme-controller or a fairplay variant of that controller specifically for the webkit prefixed API.

@valotvince

Copy link
Copy Markdown
Contributor Author

@robwalch Hello :)
I am still developing that feature (out of hls.js) but I'll contribute as soon as I have something working on my end !

@robwalch robwalch added this to the 0.14.0 milestone Mar 26, 2020
@robwalch
robwalch merged commit b729d19 into video-dev:master Mar 26, 2020
@springuper

Copy link
Copy Markdown
Contributor

@valotvince look forward to your contribution for FairPlay support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants