Prevent loading com.apple.streamingkeydelivery key format - #2606
Merged
Conversation
robwalch
approved these changes
Mar 26, 2020
Collaborator
|
@valotvince thanks for the contribution. Would you consider contributing a fairplay implementation as well? It would be great if we could handle |
Contributor
Author
|
@robwalch Hello :) |
itsjamie
approved these changes
Mar 26, 2020
3 tasks
Contributor
|
@valotvince look forward to your contribution for FairPlay support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Prevent trying to load a com.apple.streamingkeydelivery format
skd://...and warn the integrator this isn't supported out-of-the-box by hls.jsWhy is this Pull Request needed?
I am working on playing HLS fMP4 w/ Fairplay encryption
com.apple.fps.2_0with hls.js and it was creating an error while trying to loadskd://over HTTP.Preventing it allows segments to be added to Buffer/MediaSource and therefore trigger the
webkitneedkeyandwebkitkeymessageevents that I need to get a license from our DRM providerAre there any points in the code the reviewer needs to double check?
Any other KEYFORMAT should work
Checklist