Throttle final playlist reloads when using DASH#277
Merged
Conversation
ldayananda
reviewed
Nov 6, 2018
ldayananda
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. I think it might make sense to lift this logic to MPC since isFinalRendition is defined there too. But, that can be done in a follow up PR.
ldayananda
approved these changes
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HLS already throttles reloads of the final playlist, however, DASH does not. This adds the throttling behavior to the DASH playlist loader.
To see the behavior:
The failed requests will shoot up as fast as can be processed (since the retries are immediate).
The fix makes it so that retries are only made at half the target duration.
Requirements Checklist