Skip to content

Commit b67fe27

Browse files
brandonocaseygkatsev
authored andcommitted
feat: responsive caption settings (#5534)
When responsive mode is set, make the caption settings dialog be more responsive to the size of the player. Make whitespace and sizing a bit more consistent across elements.
1 parent ab0e29a commit b67fe27

File tree

1 file changed

+24
-13
lines changed

1 file changed

+24
-13
lines changed

src/css/components/_captions-settings.scss

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,30 +26,36 @@
2626
.vjs-text-track-settings .vjs-modal-dialog-content {
2727
display: grid;
2828
grid-template-columns: 1fr 1fr;
29-
grid-template-rows: 1fr auto;
29+
grid-template-rows: 1fr;
30+
// Flex and Grid for Firefox, IE, and Edge remove the bottom padding/margin in a container as size decreases
31+
// so we add bottom padding/margin to the last item in the grid instead of here
32+
// see https://stackoverflow.com/a/23754080
33+
padding: 20px 24px 0px 24px;
3034
}
3135

32-
.vjs-text-track-settings .vjs-track-settings-colors {
33-
display: block;
34-
grid-column: 1;
35-
grid-row: 1;
36-
}
37-
38-
.vjs-text-track-settings .vjs-track-settings-font {
39-
grid-column: 2;
40-
grid-row: 1;
36+
// see the comment for padding above
37+
.vjs-track-settings-controls .vjs-default-button {
38+
margin-bottom: 20px;
4139
}
4240

4341
.vjs-text-track-settings .vjs-track-settings-controls {
44-
grid-column: 2;
45-
grid-row: 2;
42+
// make this take up both columns
43+
grid-column: 1 / -1;
44+
}
4645

46+
// 1 column for small players
47+
.vjs-layout-small .vjs-text-track-settings .vjs-modal-dialog-content ,
48+
.vjs-layout-x-small .vjs-text-track-settings .vjs-modal-dialog-content,
49+
.vjs-layout-tiny .vjs-text-track-settings .vjs-modal-dialog-content {
50+
grid-template-columns: 1fr;
4751
}
52+
4853
}
4954

5055
// Form elements
5156
.vjs-track-setting > select {
52-
margin-right: 5px;
57+
margin-right: 1em;
58+
margin-bottom: 0.5em;
5359
}
5460

5561
.vjs-text-track-settings fieldset {
@@ -62,6 +68,11 @@
6268
display: inline-block;
6369
}
6470

71+
// style the second select for text colors
72+
.vjs-text-track-settings fieldset span > select {
73+
max-width: 7.3em;
74+
}
75+
6576
.vjs-text-track-settings legend {
6677
color: $primary-foreground-color;
6778
margin: 0 0 5px 0;

0 commit comments

Comments
 (0)