Permalink
Browse files

fix: Avoid empty but shown title attribute with menu items and clicka…

…ble components (#4746)
  • Loading branch information...
arski authored and gkatsev committed Nov 16, 2017
1 parent d447e9f commit dc588dd6c593e1173d31ffa5c0010a33dc627d0c
Showing with 2 additions and 3 deletions.
  1. +1 −1 src/js/clickable-component.js
  2. +1 −2 src/js/menu/menu-item.js
@@ -120,7 +120,7 @@ class ClickableComponent extends Component {
* - The control text when getting
*/
controlText(text, el = this.el()) {
if (!text) {
if (text === undefined) {
return this.controlText_ || 'Need Text';
}
View
@@ -97,8 +97,7 @@ class MenuItem extends ClickableComponent {
this.removeClass('vjs-selected');
this.el_.setAttribute('aria-checked', 'false');
// Indicate un-selected state to screen reader
// Note that a space clears out the selected state text
this.controlText(' ');
this.controlText('');
}
}
}

0 comments on commit dc588dd

Please sign in to comment.