Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Choosing a chapter doesn't hide loading spinner #179

Closed
copperdogma opened this Issue Apr 30, 2012 · 5 comments

Comments

Projects
None yet
6 participants

Someone brought this up on the website forum, but I just noticed it, too.

When you use chapters, if you open the menu and click on one it correctly shows the loading spinner, jumps to the proper timestamp, but then fails to hide the loading spinner again. It just sits there and spins forever.

If you click pause and then play again it correctly hides the loading spinner.

dezza commented Jul 3, 2012

This error also happens for me, I see the loading-spinner whenever I seek with the time or set with currentTime()

Workaround:

I added

.vjs-loading-spinner {
  display: none !important;
}

In the video.css !

I get two spinners shown. A blue one and the circle/ball-spinner .. It doesn't matter that the white one doesn't get displayed.

You could also hide the spinner with JavaScript on various events or button clicks.

I'm attempting to hide the loading spinner once the video completes. I've added this to a script that successfully changes the zIndex of the video vs. a logo on the page. However, the spinner does not disappear, as expected:

V("myVideoID").ready(function(){
$myPlayer = this; this.addEvent("ended", function(){
{...}
$(".vjs-loading-spinner").hide();
});
});

jQuery is included at the top of the page, and no errors are thrown. Any idea why this happens?

Dezza - that workaround worked for me - thanks for putting it up here.
No loading spinner is better than a loading spinner that doesn't go away!

Here is my fix, this hides the spinner when the player is not playing
.vjs-playing .vjs-loading-spinner {
display:none !important;
}

Owner

heff commented Mar 1, 2014

Thanks for the workarounds everyone. Sorry it took so long to address this. If you're still seeing issues please comment.

@heff heff closed this Mar 1, 2014

@heff heff added the bug label Mar 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment