Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

techLoad error detection #190

Closed
foxx opened this Issue May 24, 2012 · 2 comments

Comments

Projects
None yet
2 participants

foxx commented May 24, 2012

Hi,

In the event that both html5 and flash techs fail to load, VideoJS currently provides no way to alarm you to this fact.

A valid use case is when you don't want to use VideoJS for flash fallback, and instead want it to trigger an event if it fails to load, so you can handle appropriately.

The way we fixed this was by adding a 'triggerLoadError', 'loadError', and 'loaderror' html5 event (in the same style as 'ready').

Please let me know if you would consider including this improvement in the core, if so I will go ahead and do the necessary fork work.

Cheers

Cal

Owner

heff commented May 24, 2012

Absolutely, thanks.
-heff

On May 24, 2012, at 9:52 AM, Cal Leeming wrote:

Hi,

In the event that both html5 and flash techs fail to load, VideoJS currently provides no way to alarm you to this fact.

A valid use case is when you don't want to use VideoJS for flash fallback, and instead want it to trigger an event if it fails to load, so you can handle appropriately.

The way we fixed this was by adding a 'triggerLoadError', 'loadError', and 'loaderror' html5 event (in the same style as 'ready').

Please let me know if you would consider including this improvement in the core, if so I will go ahead and do the necessary fork work.

Cheers

Cal


Reply to this email directly or view it on GitHub:
zencoder#190

foxx commented May 24, 2012

Done - see pull request zencoder#191

If accepted for pull, I'll close this issue.

heff added a commit to heff/video.js that referenced this issue Mar 15, 2013

heff added a commit that referenced this issue Mar 15, 2013

Merge pull request #383 from heff/feature/track-default
Adding default to 'off' for track lists from #190

mente added a commit to mente/video-js that referenced this issue Mar 27, 2013

Merge branch 'master' into production
* master: (24 commits)
  Added contribflow as a package.
  Remove changedTouches from fixEvent because it doesn't work currently. Add comment about it in the calculateDistance method
  Don't prevent mouse actions when paused to make sure Android's Play overlay is usable.
  Remove showBigPlayButton
  Adding more detail to JSON.parse() error
  Fix indentation
  remove mouseOff
  remove console.log
  Make buttons accept tap events as well as click. Prevent mouseevents when touch is available
  Make slider touch/mouse events removable
  Fix slider for android
  Add {
  Make BigPlayButton show up when paused. Add 'showBigPlayButton' event to allow users to cancel that.
  initial support for toggling controlbar via touch
  make seekbar seekable on mobile devices.
  Reduced PNG filesize by ~4kb
  Adding default to 'off' on track menus from #190
  Close GH-378: #376 Removing Helvetica from font-family declarations..
  fix test
  update plugins.js
  ...

@heff heff closed this May 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment