Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "Unsupported Browser" modal dialog for unsupported browsers #2045

Open
tinwatchman opened this issue Apr 16, 2015 · 4 comments
Open
Labels
confirmed enhancement pinned Things that stalebot shouldn't close automatically unclaimed

Comments

@tinwatchman
Copy link

tinwatchman commented Apr 16, 2015

So here's a fun one for you... so you know how you guys are parsing the user agent string to determine whether or not a browser is IE8? The problem is that -- on _INTRA_net sites, as in on an internal network -- IE8 by default goes into Compatibility Mode. Which means its user string actually looks like this:

ie8compatmodeuseragent

Meaning the user string check fails -- meaning the code generates a whole bunch of errors afterwards, since the script doesn't know it's running in IE8. I would suggest either relying on feature detection for this, or otherwise (for a quick fix) update line 408 (or thereabouts) in lib.js from this:

var IS_IE8 = (/MSIE\s8\.0/).test(USER_AGENT);

to this:

var IS_IE8 = (/MSIE\s(7|8)\.0/).test(USER_AGENT);

If only to spare some poor idiot out there the same path I've been dealing with all afternoon here.

@heff
Copy link
Member

heff commented Apr 17, 2015

That's interesting. I'm pretty positive we don't support compatibility
mode, so we should probably detect this case specifically and show an error.

Sent from mobile

@EZWrighter
Copy link

I would agree with Tinwatchman, that the detection should at least be sane. I have used the Tim Downs answer from stackoverflow and I think it's pretty bulletproof: http://stackoverflow.com/questions/10964966/detect-ie-version-prior-to-v9-in-javascript

@gkatsev
Copy link
Member

gkatsev commented Nov 17, 2015

Would anyone want to a PR for "Unsupported Browser" Modal dialog for vjs 5?

@gkatsev
Copy link
Member

gkatsev commented Mar 28, 2016

Updating the title to "Unsupported Browser" modal.

@gkatsev gkatsev changed the title Very specific IE8 Edge Case: Script errors will occur on intranet sites Add an "Unsupported Browser" modal dialog for unsupported browsers Mar 28, 2016
@gkatsev gkatsev added the pinned Things that stalebot shouldn't close automatically label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed enhancement pinned Things that stalebot shouldn't close automatically unclaimed
Projects
None yet
Development

No branches or pull requests

5 participants