-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced Player component is not used by videojs init function #3016
Comments
Hi can you elaborate on what you mean please? |
Basically, if you want to change a behavior directly in the player object using component, videojs(id) will still use base Player object instead of the new component. I wanted to do that : var Player = videojs.getComponent('Player');
videojs.registerComponent('Player', videojs.extend(Player,{
//...
})); Then later: videojs('my_video_player'); This is not related to #3006. |
Oh, I see. I'm not sure I'd want to support something like that. It opens up videojs too much to custom code that will then be reported as issues with videojs but actually it's an issue with the custom player. |
My aim was to use the same information between several components in the control bar. I spawn to elements and these two elements will interact with the same information. When the information is changed, player has to reload several stuff (thinks same video with multiple declination on resolutions and languages). I'm overloading the player to change initial load of the video and also to change the source according to the new information and a config object given at player init. I'm not sure if this is clear. |
Return of the function is using directly a reference to Player instead of using the registered component.
The text was updated successfully, but these errors were encountered: