fix: support require()-ing video.js #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
suggested changes
Dec 23, 2016
| @@ -89,10 +96,10 @@ function autoSetupTimeout(wait, vjs) { | |||
| videojs = vjs; | |||
| } | |||
|
|
|||
| setTimeout(autoSetup, wait); | |||
| window.setTimeout(autoSetup, wait); | |||
There was a problem hiding this comment.
setTimeout is a global in node too, so this change isn't really needed
There was a problem hiding this comment.
True, but it's consistent with the rest of the codebase where we are using window.setTimeout, which will work in Node because we're using the global package.
| * @return {Boolean} | ||
| */ | ||
| export function isReal() { | ||
| return document === window.document && typeof document.createElement === 'function'; |
There was a problem hiding this comment.
this would need a typeof window !== 'undefined' and typeof document !== 'undefined', since otherwise they're a reference error in node.
There was a problem hiding this comment.
since we're using global, it returns either window or global depending on the environment, so, window should never end up being undefined.
gkatsev
approved these changes
Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes a number of small fixes to support pulling in video.js via
require()in Node.I have verified it in the following ways (using Node 4.6):
node -e "require('./dist/video.js')"node -e "require('./es5/video.js')"All these were tested because we had noticed some odd behavior when using the inline
-ecommand vs. the REPL. Success was considered "didn't throw an error".Fixes #3869.
Specific Changes proposed
Dom.isReal()function, which makes an educated assumption about the "realness" of thedocumentobject.Dom.isReal()as well as other defensive code.Requirements Checklist