Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stateful Components #3960

Merged
merged 3 commits into from
Jan 27, 2017
Merged

feat: Stateful Components #3960

merged 3 commits into from
Jan 27, 2017

Conversation

misteroneill
Copy link
Member

Description

The PR for advanced plugins introduced the concept of mixins and added two: evented and stateful.

This PR follows #3959 by providing Components with the benefits of the stateful mixin.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@brandonocasey
Copy link
Contributor

It may be worth just having one PR for these changes rather than having #3959 too. Adding the stateful mixin doesn't seem like that big of a change here.

@misteroneill
Copy link
Member Author

I split it up at @gkatsev's request. Feel free to duke it out with him. 😛

@gkatsev gkatsev merged commit d7d7cfe into master Jan 27, 2017
@gkatsev gkatsev deleted the stateful-component branch January 27, 2017 03:04
@gkatsev gkatsev moved this from In Progress to Done in 6.0 Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
6.0
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants