Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can lose focus from ModalDialog when it is opened if shift-tab is hit #4049

Closed
gkatsev opened this issue Feb 9, 2017 · 0 comments
Closed

Can lose focus from ModalDialog when it is opened if shift-tab is hit #4049

gkatsev opened this issue Feb 9, 2017 · 0 comments
Assignees
@gkatsev
Labels
a11y This item might affect the accessibility of the player

Comments

@gkatsev
Copy link
Member

gkatsev commented Feb 9, 2017

When the ModalDialog is opened, we focus on the ModalDialog element itself. We then trap the tab focus inside of it. This is works fine if we hit tab after the ModalDialog opens. However, we only check for tabbable items inside of the Modal, which works fine if you tab forward. However, tabbing back in this case doesn't bring you to the last element as it should. This probably needs to be special cased in the current logic.
@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Feb 9, 2017
@gkatsev gkatsev mentioned this issue Feb 9, 2017
Merged
13 tasks
gkatsev added a commit that referenced this issue Feb 13, 2017
@gkatsev
fix: trap tab focus in modal when hitting s-tab
1fffd06 
Pretend that the modal dialog is equivalent to the first
focusable/tabbable element when hitting shift-tab.

Fix #4049
@gkatsev gkatsev mentioned this issue Feb 13, 2017
Merged
@gkatsev gkatsev self-assigned this Feb 13, 2017
gkatsev added a commit that referenced this issue Feb 21, 2017
@gkatsev
fix: trap tab focus in modal when hitting s-tab (#4075)
1f7a842 
Pretend that the modal dialog is equivalent to the first
focusable/tabbable element when hitting shift-tab.

Fix #4049
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkatsev gkatsev

Labels
a11y This item might affect the accessibility of the player
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkatsev