docs: Add MediaLoader to components list #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should just get rid of it altogether. |
gkatsev
approved these changes
Feb 13, 2017
|
I don't think a div is necessary. For example, in the React community, they've found a pretty nice pattern of having container and presentational components. container components usually don't have any UI associated with them while presentational components do. Though, both are React Classes. I would put the MediaLoader is a category similar to the container component, so, it doesn't require one. |
5 tasks
gkatsev
pushed a commit
that referenced
this pull request
Feb 21, 2017
MediaLoader has a div that's unnecessary. See #4070. Also, make sure that Component#dispose does a null check for the element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated list.
As an aside, should the loader's
divhave a class so it's obvious what it is when looking at the DOM?