-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update track mode if changed #4298
Conversation
cc @gkatsev what do you think |
track.mode = 'disabled'; | ||
if (track.mode !== 'disabled') { | ||
track.mode = 'disabled'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is complaining about this not being combined with the else
, like so:
} else if (track.mode !== 'disabled') {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go assuming tests and linter passed. I updated the PR by consolidated the if statements.
@arski thanks! Would you be able to make a similar PR against the 5.x branch? I can take care of that otherwise. |
@gkatsev thanks! would you mind doing against the 5.x branch? Im not sure when ill get to it :( btw how frequently do you bump versions for the lib? |
Sure, I'll make a PR for it. As for how often, it really just depends on whether there's things to release, we don't really have a strict release schedule right now, though, I want to try and aim for regular releases. 6.x with this fix has been released already. |
Aha nice, good to know! |
Made a PR against 5.x in #4368. |
Hi there,
Would you consider this fix for triggering less track.modechange and subsequently trackList.change events - at the moment too many of those are triggered even if nothing has actually changed.
cc #4294