Only update track mode if changed #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gkatsev what do you think |
misteroneill
requested changes
Apr 26, 2017
| track.mode = 'disabled'; | ||
| if (track.mode !== 'disabled') { | ||
| track.mode = 'disabled'; | ||
| } |
There was a problem hiding this comment.
The linter is complaining about this not being combined with the else, like so:
} else if (track.mode !== 'disabled') {
gkatsev
approved these changes
May 8, 2017
misteroneill
approved these changes
May 12, 2017
|
@arski thanks! Would you be able to make a similar PR against the 5.x branch? I can take care of that otherwise. |
|
@gkatsev thanks! would you mind doing against the 5.x branch? Im not sure when ill get to it :( btw how frequently do you bump versions for the lib? |
|
Sure, I'll make a PR for it. As for how often, it really just depends on whether there's things to release, we don't really have a strict release schedule right now, though, I want to try and aim for regular releases. 6.x with this fix has been released already. |
|
Aha nice, good to know! |
|
Made a PR against 5.x in #4368. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Would you consider this fix for triggering less track.modechange and subsequently trackList.change events - at the moment too many of those are triggered even if nothing has actually changed.
cc #4294