Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player reset() should reset UI state of control bar etc #4683

Closed
www-wwj opened this issue Oct 24, 2017 · 6 comments
Closed

player reset() should reset UI state of control bar etc #4683

www-wwj opened this issue Oct 24, 2017 · 6 comments
Labels
help wanted pinned Things that stalebot shouldn't close automatically

Comments

@www-wwj
Copy link

www-wwj commented Oct 24, 2017

Description

when i use reset() api, controlBar UI not reset

Steps to reproduce

  1. playing video
  2. call reset function
@gkatsev
Copy link
Member

gkatsev commented Oct 24, 2017

Can you elaborate on what you mean by the control bar UI not being reset?

@www-wwj www-wwj changed the title player reset() not work will player reset() not work Oct 24, 2017
@www-wwj
Copy link
Author

www-wwj commented Oct 24, 2017

when i execute player.reset() , the vjs-control-bar has not be reset. The status of play buttom is playing, the progress-control UI is not right too
image

@gogoku
Copy link

gogoku commented Dec 1, 2017

Any update on this issue?, i am still facing the same issue
#3816 trying to use this solution to update the video player

@gkatsev
Copy link
Member

gkatsev commented Dec 1, 2017

No update yet, we should reset the control when reset is called, but its main purpose was to reset the state of the techs, which it does. Any help with this would be appreciated.

@gogoku
Copy link

gogoku commented Dec 2, 2017

i guess calling dispose to remove the player from the dom and adding again is the right way to do it ,
Can you please tell me , What is the case that reset tech is used for?

@stale
Copy link

stale bot commented Aug 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Aug 10, 2018
@gkatsev gkatsev added pinned Things that stalebot shouldn't close automatically and removed outdated Things closed automatically by stalebot labels Aug 10, 2018
@gkatsev gkatsev changed the title player reset() not work player reset() should reset UI state of control bar etc Aug 10, 2018
@gkatsev gkatsev closed this as completed in 175f773 Jan 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted pinned Things that stalebot shouldn't close automatically
Projects
None yet
Development

No branches or pull requests

3 participants