New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle mouse can play/pause videojs #4689

Closed
kocoten1992 opened this Issue Oct 25, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@kocoten1992
Contributor

kocoten1992 commented Oct 25, 2017

Steps to reproduce

  1. go to videojs.com
  2. press play
  3. now, you can use middle mouse to play/pause video (click on the video, not triangle play button)

Expected

Shouldn't be able to do that

Problem might be here:
https://github.com/videojs/video.js/blob/master/src/js/player.js#L1384

Related issue: #4611 (fixing that will give enough experience to fix this)

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 25, 2017

Member

I wasn't able to reproduce but I can definitely see it happening on some browsers and OSes.

Member

gkatsev commented Oct 25, 2017

I wasn't able to reproduce but I can definitely see it happening on some browsers and OSes.

kocoten1992 added a commit to kocoten1992/video.js that referenced this issue Nov 17, 2017

gkatsev added a commit that referenced this issue Nov 17, 2017

fix: being able to toggle playback with middle click (#4756)
Uses the new Dom.isSingleLeftClick method to do the check we were doing previously.
Also, refactor the player.handleTechClick_() method to follow the new style of code.

Fixes #4689
@sziberov

This comment has been minimized.

Show comment
Hide comment
@sziberov

sziberov Nov 22, 2017

Can do this too.
v5.4.6
Opera Developer
Windows 10

sziberov commented Nov 22, 2017

Can do this too.
v5.4.6
Opera Developer
Windows 10

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Nov 22, 2017

Member

@sziberov it's fixed in 6.5.0, please give that a try!

Member

gkatsev commented Nov 22, 2017

@sziberov it's fixed in 6.5.0, please give that a try!

@sziberov

This comment has been minimized.

Show comment
Hide comment
@sziberov

sziberov Nov 26, 2017

@gkatsev Yeah, it is, but time tooltip and volume bar styling completely broken now. What I can do?

sziberov commented Nov 26, 2017

@gkatsev Yeah, it is, but time tooltip and volume bar styling completely broken now. What I can do?

@kocoten1992

This comment has been minimized.

Show comment
Hide comment
@kocoten1992

kocoten1992 Nov 27, 2017

Contributor

@sziberov open new issue, take a picture before and after maybe, I recall the slider have box-shadow (but never really show before, only show after fix the left click), didn't recall time tooltip though

Contributor

kocoten1992 commented Nov 27, 2017

@sziberov open new issue, take a picture before and after maybe, I recall the slider have box-shadow (but never really show before, only show after fix the left click), didn't recall time tooltip though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment