New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest build fail, HEAD is now at 79639138 #4706

Closed
kocoten1992 opened this Issue Oct 31, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@kocoten1992
Contributor

kocoten1992 commented Oct 31, 2017

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. git clone https://github.com/videojs/video.js
  2. npm install
  3. npm run test

It fail by open() hides controls, close() shows controls at test/unit/modal-dialog.test.js

@kocoten1992 kocoten1992 referenced this issue Oct 31, 2017

Merged

refactor player.dimension() #4704

1 of 1 task complete
@mister-ben

This comment has been minimized.

Show comment
Hide comment
@mister-ben

mister-ben Oct 31, 2017

Contributor

I believe #4690 is causing this

Contributor

mister-ben commented Oct 31, 2017

I believe #4690 is causing this

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Oct 31, 2017

Member

Thanks, yeah, I noticed that it was failing after merging in but didn't have the time to fix it last night.

Member

gkatsev commented Oct 31, 2017

Thanks, yeah, I noticed that it was failing after merging in but didn't have the time to fix it last night.

gkatsev added a commit that referenced this issue Oct 31, 2017

test: fix modal dialog test for showing controls
Also, add a test that verifies the behavior for the PR (#4690).

Fixes #4706.

gkatsev added a commit that referenced this issue Oct 31, 2017

test: fix modal dialog test for showing controls (#4707)
Also, add a test that verifies the behavior for the PR (#4690).

Fixes #4706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment