GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain in detail the exact steps necessary to reproduce the issue.
It fail by open() hides controls, close() shows controls at test/unit/modal-dialog.test.js
open() hides controls, close() shows controls
I believe #4690 is causing this
Thanks, yeah, I noticed that it was failing after merging in but didn't have the time to fix it last night.
test: fix modal dialog test for showing controls
Also, add a test that verifies the behavior for the PR (#4690).
test: fix modal dialog test for showing controls (#4707)