Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to prevent the play button changing to a replay button after the video completes? #4802

Closed
chrisbell08 opened this issue Dec 10, 2017 · 7 comments

Comments

@chrisbell08
Copy link

@chrisbell08 chrisbell08 commented Dec 10, 2017

Is there an option to prevent replay on completion? The click on the video to replay functionality I can fix just by overlaying a div I guess but the control bar play button switching to a replay button is a little trickier

@thijstriemstra
Copy link
Contributor

@thijstriemstra thijstriemstra commented Dec 12, 2017

listen for finish/complete event and remove the related css class (vjs-end or something)?

@gkatsev
Copy link
Member

@gkatsev gkatsev commented Jan 2, 2018

Maybe this is something that should be configurable? We had a lot of requests to add this in 5 and we liked this direction as well so we made this change but if not everyone likes it, maybe it should just be configurable. Thoughts @videojs/core-committers?

@chrisbell08
Copy link
Author

@chrisbell08 chrisbell08 commented Jan 3, 2018

I think that would be handy,

I had to do it with this line of code in the ended event:
this.videoHandler.controlBar.playToggle.removeClass('vjs-ended');

an option would be much cleaner

@ldayananda
Copy link
Contributor

@ldayananda ldayananda commented Jan 3, 2018

An option seems reasonable

@stale
Copy link

@stale stale bot commented Aug 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@arshadkazmi42
Copy link

@arshadkazmi42 arshadkazmi42 commented Aug 20, 2018

I can take this up. if its still available

@brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Aug 20, 2018

Yeah I think this is something we would still like an option for, if you want to take it on @arshadkazmi42 , go for it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants