es6 import of a language file does not work

[axten]

Description

if I try to import a language file I got ReferenceError: videojs is not defined

so any lang file should have an import statement befor videojs to fix this.
besides that, a work around could be to provide the pure json files in videojs build.
this also would be great to extend a language during project build.

Steps to reproduce

just do

import videojs from 'video.js';
import 'video.js/dist/lang/de';

Results

Expected

should work as expected

Actual

it breaks

Additional Information

videojs: 6.8.0

[gkatsev]

Oops, I guess the language files we build expect videojs to be available globally. We the build system for them a long time ago before importing/requiring and bundling was popular. We should revisit it soon.

[axten]

so in the meantime it would be great to have the pure json files in the npm package

[hojas]

+1

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gkatsev]

@axten want to submit a PR that adds the json files to the npm publish?

[axten]

I'm not shure how this works in your pipeline

[michelson]

👍

[eranshmil]

I think you could close this issue since PR #5549 has been merged.

[gkatsev]

I think I'd like to keep this open for a bit longer to see if we can figure out a better solution.
Potentially, compile the json files into a .mjs file that imports video.js at the top of the file.