es6 import of a language file does not work #5092
Comments
axten
changed the title
|
Oops, I guess the language files we build expect videojs to be available globally. We the build system for them a long time ago before importing/requiring and bundling was popular. We should revisit it soon. |
|
so in the meantime it would be great to have the pure json files in the npm package |
|
+1 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@axten want to submit a PR that adds the json files to the npm publish? |
|
I'm not shure how this works in your pipeline |
|
|
This helps with ESM import and bundler users can then import the JSON files directly and register the languages manually. For example:
```js
import es from 'video.js/dist/lang/es.json';
videojs(element, {
language: 'es',
languages: {
es
}
});
```
Related issue: #5092
|
I think you could close this issue since PR #5549 has been merged. |
|
I think I'd like to keep this open for a bit longer to see if we can figure out a better solution. |
Description
if I try to import a language file I got
ReferenceError: videojs is not definedso any lang file should have an import statement befor videojs to fix this.
besides that, a work around could be to provide the pure json files in videojs build.
this also would be great to extend a language during project build.
Steps to reproduce
just do
Results
Expected
should work as expected
Actual
it breaks
Additional Information
videojs: 6.8.0
The text was updated successfully, but these errors were encountered: