Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change remaining-time-display.js so that the time value announced by a screen reader is not negative #5168

Closed
OwenEdwards opened this issue May 10, 2018 · 1 comment

Comments

@OwenEdwards
Copy link
Member

@OwenEdwards OwenEdwards commented May 10, 2018

Description

As mentioned in #5157, the convention to display the remaining time in a video as a negative number is purely a visual convention; for screen reader users, where the remaining time has a hidden label, the actual amount of remaining time is positive, not negative.

So the remaining-time-display.js component should either add the negative sign in a way that is decorative and not announced by screen readers, or the visual (negative) number should be aria-hidden from screen readers and a hidden positive value should be added.

@smbea
Copy link
Contributor

@smbea smbea commented Dec 5, 2018

@gkatsev Hello, this is my approach for fixing the issue. I made it so the '-' is added on every time remaining update in a purely decorative way. I was wondering if this fits the what you had in mind for the solution or it should be a more efficient one.

You can see the screenshots of the solution working:

screenshot 2018-12-05 at 21 12 19
screenshot 2018-12-05 at 21 12 29

And here are the changes made:

screenshot 2018-12-05 at 21 13 54
screenshot 2018-12-05 at 21 14 00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants