New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.2.0 to 7.2.2 playback does not restart after ended #5436

Closed
Everlag opened this Issue Sep 12, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@Everlag

Everlag commented Sep 12, 2018

Description

Video fails to play after its reaches the end. This also breaks looping.

Repro(Note the version pulled in from cdnjs):
http://jsbin.com/repipayogu/1/edit?html,output

Steps to reproduce

  1. Let video end(seeking to near end is fine); play button should change to replay
  2. Press play

Results

Expected

Video plays again

Actual

Video fails to play; loading spinner spins continuously
Please describe what actually happened.

Error output

If there are any errors at all, please include them here.

Additional Information

Seeking to the start with or without invoking play successfully restarts playback.

7.2.0 to 7.2.2 changes the http-streaming version from 1.1.0 to 1.2.4

versions

videojs

7.2.2 fails to play

7.2.0 does not fail to play

7.1.0 does not fail to play

browsers

Chrome; others may be affected

OSes

Windows, OSX, and Linux

plugins

http-streaming(videojs 7 builtin)

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Sep 12, 2018

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

welcome bot commented Sep 12, 2018

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@Everlag Everlag changed the title from 7.1.0 to 7.2.2 playback does not restart after ended to 7.2.0 to 7.2.2 playback does not restart after ended Sep 12, 2018

@bcdarius

This comment has been minimized.

Show comment
Hide comment
@bcdarius

bcdarius Sep 12, 2018

Contributor

This issue was fixed in @videojs/http-streaming v1.2.5 (v7.2.2 is still on v1.2.4). VHS version containing a fix, I believe, will be upgraded in the upcoming VideoJS release.

Contributor

bcdarius commented Sep 12, 2018

This issue was fixed in @videojs/http-streaming v1.2.5 (v7.2.2 is still on v1.2.4). VHS version containing a fix, I believe, will be upgraded in the upcoming VideoJS release.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Sep 13, 2018

Member

7.2.3 is now out with this fix!

Member

gkatsev commented Sep 13, 2018

7.2.3 is now out with this fix!

@gkatsev gkatsev closed this Sep 13, 2018

@Everlag

This comment has been minimized.

Show comment
Hide comment
@Everlag

Everlag Sep 14, 2018

Looping still seems to be broken. Manually invoking play is solved by the latest release but we still see the spinner blocking at the end when it should loop.

Want me to open a new issue for this?

Repro
http://jsbin.com/kamavaduru/1/edit?html,output

Everlag commented Sep 14, 2018

Looping still seems to be broken. Manually invoking play is solved by the latest release but we still see the spinner blocking at the end when it should loop.

Want me to open a new issue for this?

Repro
http://jsbin.com/kamavaduru/1/edit?html,output

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev Sep 14, 2018

Member

@Everlag can you open one against the videojs/http-streaming repo? Thanks!

Member

gkatsev commented Sep 14, 2018

@Everlag can you open one against the videojs/http-streaming repo? Thanks!

@Everlag

This comment has been minimized.

Show comment
Hide comment
@Everlag

Everlag commented Sep 14, 2018

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment