Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the reduced test case starter template #5562

Closed
OwenEdwards opened this issue Nov 8, 2018 · 2 comments
Closed

Update the reduced test case starter template #5562

OwenEdwards opened this issue Nov 8, 2018 · 2 comments

Comments

@OwenEdwards
Copy link
Member

@OwenEdwards OwenEdwards commented Nov 8, 2018

Description

The starter template on JSBin uses http for its links even though JS Bin itself forces the URL to use https. This causes some failures.

The template also uses video.js v5, which is deprecated now; it needs updating to v6.

@gkatsev
Copy link
Member

@gkatsev gkatsev commented Nov 9, 2018

I created a codepen template that we can start using: https://codepen.io/gkatsev/pen/GwZegv?editors=1010#0

Loading

gkatsev added a commit that referenced this issue Nov 9, 2018
Use a codepen template for the starter template that includes a 7.x
player, video-js element, and a JavaScript created player.

The template is https://codepen.io/gkatsev/pen/GwZegv?editors=1010#0

Fixes #5562
@gkatsev
Copy link
Member

@gkatsev gkatsev commented Nov 9, 2018

Made a PR for it #5570

Loading

gkatsev added a commit that referenced this issue Nov 14, 2018
Use a codepen template for the starter template that includes the latest version of Video.js.

The template is at https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0

Fixes #5562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants