New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vjs-ended class stays on container element after scrubbing video location until play #5654

Closed
KevinBrogan opened this Issue Dec 5, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@KevinBrogan
Copy link

KevinBrogan commented Dec 5, 2018

Description

When a video ends and the vjs-ended class is added to the container element, I would expect that when changing the video position with the scrub bar, moving from the end of the video to any other position, that the vjs-ended class is removed. Instead, the vjs-ended class stays until the video is unpaused from its new position.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Play a video to the end
  2. move the scrub bar some where that isn't the end

Results

Expected

I expect the vjs-ended class to be removed since the video is no longer at the end, just as it is removed from the play/pause/replay button.

Actual

The class stays until play is resumed.

Error output

no errors

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

7.3

browsers

chrome

OSes

windows

plugins

none

@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Dec 11, 2018

Can confirm this happens.

gkatsev added a commit that referenced this issue Jan 4, 2019

fix(player): remove vjs-ended class on seeked
Whenever we seek after the video has ended, we are no longer ended and
therefore we should remove the vjs-ended class.

Fixes #5654.
@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Jan 4, 2019

I have a fix for this here #5728

@gkatsev gkatsev closed this in #5728 Jan 8, 2019

gkatsev added a commit that referenced this issue Jan 8, 2019

fix(player): remove vjs-ended class on seeked (#5728)
Whenever we seek after the video has ended, we are no longer ended and
therefore we should remove the vjs-ended class.

Fixes #5654.

gkatsev added a commit that referenced this issue Jan 8, 2019

fix(player): remove vjs-ended class on seeked (#5728)
Whenever we seek after the video has ended, we are no longer ended and
therefore we should remove the vjs-ended class.

Fixes #5654.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment