New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced webkitRequestFullScreen with webkitRequestFullscreen #1101

Merged
merged 1 commit into from May 7, 2014

Conversation

Projects
None yet
3 participants
@michelt
Contributor

michelt commented Mar 20, 2014

reffered to issue #1100

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff Mar 24, 2014

Member

Thanks! Have you tested this on both iOS and desktop Safari?

Member

heff commented Mar 24, 2014

Thanks! Have you tested this on both iOS and desktop Safari?

@mmcc mmcc changed the title from Replaced webkitRequestFullScreen with webkitReplaceFullscreen to Replaced webkitRequestFullScreen with webkitRequestFullscreen Apr 11, 2014

@heff heff referenced this pull request Apr 18, 2014

Closed

Fixes issue #673 #1155

@paruls

This comment has been minimized.

Show comment
Hide comment
@paruls

paruls Apr 29, 2014

I tried this on both iOS (6.0.1) and desktop Safari with the sandbox setup. It looks good- I didn't run into any issues or errors

paruls commented Apr 29, 2014

I tried this on both iOS (6.0.1) and desktop Safari with the sandbox setup. It looks good- I didn't run into any issues or errors

@heff heff merged commit 61eb54a into videojs:master May 7, 2014

1 check passed

default The Travis CI build passed
Details
@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 7, 2014

Member

Thanks!

Member

heff commented May 7, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment