New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation failures with LESS v1.7.0 and GRUNT v0.4.4 #1180

Merged
merged 1 commit into from May 9, 2014

Conversation

Projects
None yet
2 participants
@fobiaxx
Contributor

fobiaxx commented Apr 29, 2014

The operations on the variables must be enclosed in parentheses so the compiler takes as math operations and not as strings.

Fixed compilation failure with LESS v1.7.0 and GRUNT v0.4.4. The oper…
…ations on the variables must be enclosed in parentheses so the compiler takes as math operations and not as strings.
@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 2, 2014

Member

Cool, thanks! This is backwards compatible, right?

Member

heff commented May 2, 2014

Cool, thanks! This is backwards compatible, right?

@heff heff added the enhancement label May 2, 2014

@@ -926,12 +926,12 @@ body.vjs-full-window {
.absolute-align (@align, @margin, @length) when (@align = center) {
/* Center it horizontally *///
left: 50%;
margin-left: -(@length / 2);
margin-left: ((@length*-1)/2);

This comment has been minimized.

@heff

heff May 2, 2014

Member

Here it's now less obvious at first glance that this is a negative margin. Could this also be written as ( -(@length/2))?

@heff

heff May 2, 2014

Member

Here it's now less obvious at first glance that this is a negative margin. Could this also be written as ( -(@length/2))?

@fobiaxx

This comment has been minimized.

Show comment
Hide comment
@fobiaxx

fobiaxx May 3, 2014

Contributor

Sorry for my English is really bad.

The operation you mention I should be correct but In principle not because
preprocessing LESS with GRUNT, out this operation like a strings, or at
least that I can think of in my compilation.

It will be a bug LESS with my version of NODE?
El 03/05/2014 00:01, "Steve Heffernan" notifications@github.com escribió:

Cool, thanks! This is backwards compatible, right?


Reply to this email directly or view it on GitHubhttps://github.com/videojs/video.js/pull/1180#issuecomment-42083546
.

Contributor

fobiaxx commented May 3, 2014

Sorry for my English is really bad.

The operation you mention I should be correct but In principle not because
preprocessing LESS with GRUNT, out this operation like a strings, or at
least that I can think of in my compilation.

It will be a bug LESS with my version of NODE?
El 03/05/2014 00:01, "Steve Heffernan" notifications@github.com escribió:

Cool, thanks! This is backwards compatible, right?


Reply to this email directly or view it on GitHubhttps://github.com/videojs/video.js/pull/1180#issuecomment-42083546
.

@heff heff changed the title from Fixed compilation failure with LESS v1.7.0 and GRUNT v0.4.4. The operati... to Fixed compilation failures with LESS v1.7.0 and GRUNT v0.4.4 May 9, 2014

@heff heff merged commit 923ce03 into videojs:master May 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 9, 2014

Member

Merged. Thank you!

Member

heff commented May 9, 2014

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment