Better error handling (builds on #1191) #1197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added sinon.js for stubs in tests. Updated grunt version to satisfy peer dependency warning.
Now clearing errors on loadstart events. Added some default error messages.
Closed
| } | ||
|
|
||
| .vjs-error .vjs-error-display:before { | ||
| // content: @play-icon; |
There was a problem hiding this comment.
It's nit picking I know, but do we want these comments here for content and font?
|
I've made a couple of minor notes, and reached out directly to discuss customization options on the work enclosed, but otherwise think this is good to go. |
This was referenced May 13, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly rebased 1191 and screwed it up, so just created a new PR.