-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling (builds on #1191) #1197
Conversation
Added sinon.js for stubs in tests. Updated grunt version to satisfy peer dependency warning.
Now clearing errors on loadstart events. Added some default error messages.
} | ||
|
||
.vjs-error .vjs-error-display:before { | ||
// content: @play-icon; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nit picking I know, but do we want these comments here for content and font?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
I've made a couple of minor notes, and reached out directly to discuss customization options on the work enclosed, but otherwise think this is good to go. |
I mistakenly rebased 1191 and screwed it up, so just created a new PR.