New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernized the fullscreen API and added support for IE11. fixes #1155 #1205

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@heff
Member

heff commented May 14, 2014

Built on top of #1155. Also fixes #673.

@heff heff referenced this pull request May 14, 2014

Closed

Fixes issue #673 #1155

videojs.Player.prototype.requestFullScreen = function(){};
videojs.Player.prototype.cancelFullScreen = function(){};
videojs.Player.prototype.isFullscreen = function(){};
videojs.Player.prototype.isFullScreen = function(){}; /* deprecated */

This comment has been minimized.

@gkatsev

gkatsev May 14, 2014

Member

consider a log with a deprecation warning rather than just a noop.

@gkatsev

gkatsev May 14, 2014

Member

consider a log with a deprecation warning rather than just a noop.

This comment has been minimized.

@heff

heff May 14, 2014

Member

good idea

@heff

heff May 14, 2014

Member

good idea

This comment has been minimized.

@heff

heff May 15, 2014

Member

Added the warnings in player.js. This specific file is just the externs file.

@heff

heff May 15, 2014

Member

Added the warnings in player.js. This specific file is just the externs file.

This comment has been minimized.

@gkatsev

gkatsev May 15, 2014

Member

Oh, I see, didn't realize that.

@gkatsev

gkatsev May 15, 2014

Member

Oh, I see, didn't realize that.

@gkatsev

This comment has been minimized.

Show comment
Hide comment
@gkatsev

gkatsev May 14, 2014

Member

Looks good. Much more organized.

Member

gkatsev commented May 14, 2014

Looks good. Much more organized.

@tomjohnson916

This comment has been minimized.

Show comment
Hide comment
@tomjohnson916

tomjohnson916 May 14, 2014

Contributor

I think this will require an update to the IMA3 plugin. Otherwise I agree this looks more refined.

Contributor

tomjohnson916 commented May 14, 2014

I think this will require an update to the IMA3 plugin. Otherwise I agree this looks more refined.

@heff heff added confirmed labels May 15, 2014

@heff heff closed this in 46aa551 May 15, 2014

@heff heff deleted the heff:m0v0nage-master branch Jul 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment