New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check and error message for undefined techs #1210

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dominic-p
Contributor

dominic-p commented May 14, 2014

This provides a more user friendly error when a tech listed in the videojs.options array isn't defined. Definitely feel free to tweak the wording of the error message if you feel it can be clearer.

Added check and error message for undefined techs
The provides a more user friendly error when a tech listed in the
`videojs.options` array isn't defined.
@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 15, 2014

Member

Awesome, thanks! The CI is reporting an error. Would you mind checking that out?

Member

heff commented May 15, 2014

Awesome, thanks! The CI is reporting an error. Would you mind checking that out?

Fixed trailing whitespace
This was causing the build to fail for some reason.
@dominic-p

This comment has been minimized.

Show comment
Hide comment
@dominic-p

dominic-p May 15, 2014

Contributor

Ok, the CI looks like it's passing now. Apparently, it didn't like the way I formatted the white space.

Contributor

dominic-p commented May 15, 2014

Ok, the CI looks like it's passing now. Apparently, it didn't like the way I formatted the white space.

@heff heff added confirmed labels May 16, 2014

@heff heff closed this in f3ab261 May 19, 2014

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 19, 2014

Member

Pulled in, thanks!

Member

heff commented May 19, 2014

Pulled in, thanks!

@dominic-p dominic-p deleted the dominic-p:undefined-tech-bug branch Jun 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment